Skip to content

Config redesign part 2 #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Oct 20, 2025
Merged

Config redesign part 2 #1387

merged 33 commits into from
Oct 20, 2025

Conversation

@alyssajoyner
Copy link
Contributor

@alyssajoyner alyssajoyner commented Oct 6, 2025 •
edited
Loading

This PR is the next step in a larger project to redesign and improve the ClickHouse data source configuration experience.

Summary

  • Added Database credentials, TLS/SSL settings and Additional settings to their own collapsable containers.
  • Updated Optional HTTP settings component.
  • Updated the TLS/SSL settings section to have checkboxes.
  • Updated LeftSidebar to be sticky when a user scrolls.
  • Add optional badge to header of the collapsable containers that are optional.
  • Added tracking events to Rudderstack and tests.
  • Added responsive design for smaller screen sizes.
2025-10-07.14-36-37.mp4

@alyssajoyner alyssajoyner self-assigned this Oct 6, 2025
@alyssajoyner alyssajoyner requested a review from a team as a code owner October 6, 2025 21:52
@alyssajoyner alyssajoyner moved this from Incoming to Needs Review in Partner Datasources Oct 6, 2025
SpencerTorres
SpencerTorres approved these changes Oct 7, 2025
View reviewed changes
Copy link
Collaborator

@SpencerTorres SpencerTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you! 🚀

@nadinevehling

This comment was marked as outdated.

Sign in to view
bossinc
bossinc reviewed Oct 10, 2025
View reviewed changes
Copy link
Collaborator

@bossinc bossinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits that we should prob fix before merging

@bossinc
Copy link
Collaborator

bossinc commented Oct 10, 2025

Great job 🎉 ✨

@alyssajoyner alyssajoyner requested a review from bossinc October 13, 2025 17:01
bossinc
bossinc previously approved these changes Oct 14, 2025
View reviewed changes
@alyssajoyner alyssajoyner requested a review from bossinc October 14, 2025 20:57
adamyeats
adamyeats reviewed Oct 20, 2025
View reviewed changes
@alyssajoyner alyssajoyner enabled auto-merge (squash) October 20, 2025 20:22
@alyssajoyner alyssajoyner merged commit 1e4a617 into main Oct 20, 2025
18 checks passed
@alyssajoyner alyssajoyner deleted the alyssa/config-redesign-part-2 branch October 20, 2025 20:23
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Partner Datasources Oct 20, 2025
@alyssajoyner alyssajoyner mentioned this pull request Oct 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bossinc bossinc bossinc approved these changes

@aangelisc aangelisc Awaiting requested review from aangelisc aangelisc is a code owner automatically assigned from grafana/partner-datasources

@zoesyc zoesyc Awaiting requested review from zoesyc zoesyc is a code owner automatically assigned from grafana/partner-datasources

@nadinevehling nadinevehling Awaiting requested review from nadinevehling

@adamyeats adamyeats Awaiting requested review from adamyeats

+1 more reviewer

@SpencerTorres SpencerTorres SpencerTorres approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alyssajoyner alyssajoyner

Labels

None yet

Projects

Partner Datasources
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alyssajoyner @nadinevehling @bossinc @adamyeats @SpencerTorres